feat(ts): scaffold ember-ts client with proto codegen - #308
Merged
Conversation
adds clients/ember-ts/ with Makefile, package.json, and tsconfig.json. wires the root Makefile proto-ts target to delegate to the new client Makefile, matching the proto-go and proto-py pattern. generates 160 TypeScript type definitions from ember.proto via @grpc/proto-loader's proto-loader-gen-types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
adds
clients/ember-ts/and wiresmake proto-tsto actually run codegen, matching the pattern already established byproto-goandproto-py.clients/ember-ts/Makefile—proto-gentarget usingnpx @grpc/proto-loader proto-loader-gen-typesclients/ember-ts/package.json— declares@grpc/grpc-jsand@grpc/proto-loaderdependencies, mirrors pyproject.toml's minimal styleclients/ember-ts/tsconfig.json— standard strict config targeting ES2020/commonjsMakefile—proto-tsnow delegates toclients/ember-ts && make proto-geninstead of printing instructionscodegen uses
npx --yes --package=@grpc/proto-loader proto-loader-gen-typesso no global install is required — same zero-install philosophy as python'spython3 -m grpc_tools.protoc.what was tested
make proto-tsruns end-to-end and generates 160 TypeScript type files underclients/ember-ts/src/generated/ember/v1/cd clients/ember-ts && make proto-gen)EmberCache.tscontains the full service client interfacedesign notes
the generated files are committed (matching the Go and Python clients).
src/generated/can be excluded later if the team prefers codegen-on-install, but keeping parity with the other clients for now.